Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add permissions to update ingress k8s resources #1692

Merged
merged 3 commits into from
May 31, 2023
Merged

fix: Add permissions to update ingress k8s resources #1692

merged 3 commits into from
May 31, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 26, 2023

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1692 (9a7d6aa) into main (02ce774) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 9a7d6aa differs from pull request most recent head 9c3578b. Consider uploading reports for the commit 9c3578b to get more accurate results

@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
- Coverage   59.93%   59.76%   -0.17%     
==========================================
  Files          70       70              
  Lines        8332     8292      -40     
==========================================
- Hits         4994     4956      -38     
+ Misses       2992     2989       -3     
- Partials      346      347       +1     

see 3 files with indirect coverage changes

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I recall this PR might have a conflict with #1672

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit a716caf into main May 31, 2023
@tolusha tolusha deleted the 22166 branch May 31, 2023 08:11
@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants